path: root/builtin/fetch-pack.c
diff options
authorJeff King <>2018-12-18 12:47:50 (GMT)
committerJunio C Hamano <>2019-01-10 19:15:37 (GMT)
commite20b4192a3783f5e2241cce5a439933941836a99 (patch)
treef0f75c6a63279124cfdd6d14099cc591b6e0e061 /builtin/fetch-pack.c
parent98cdfbb84ad2ed6a2eb43dafa357a70a4b0a0fad (diff)
upload-pack: support hidden refs with protocol v2
In the v2 protocol, upload-pack's advertisement has been moved to the "ls-refs" command. That command does not respect hidden-ref config (like transfer.hiderefs) at all, and advertises everything. While there are some features that are not supported in v2 (e.g., v2 always allows fetching any sha1 without respect to advertisements), the lack of this feature is not documented and is likely just a bug. Let's make it work, as otherwise upgrading a server to a v2-capable git will start exposing these refs that the repository admin has asked to remain hidden. Note that we assume we're operating on behalf of a fetch here, since that's the only thing implemented in v2 at this point. See the in-code comment. We'll have to figure out how this works when the v2 push protocol is designed (both here in ls-refs, but also rejecting updates to hidden refs). Signed-off-by: Jeff King <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'builtin/fetch-pack.c')
0 files changed, 0 insertions, 0 deletions