diff options
| author | Jeff King <peff@peff.net> | 2023-03-22 17:37:17 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2023-03-22 22:37:08 (GMT) |
| commit | 76e50f7fbccb9db4659f1e7fea55fc4d51144d7c (patch) | |
| tree | be5d5368518d778521419d22199b24fb01ae1120 /builtin/fast-export.c | |
| parent | 27d43aaaf50ef0ae014b88bba294f93658016a2e (diff) | |
| download | git-76e50f7fbccb9db4659f1e7fea55fc4d51144d7c.zip git-76e50f7fbccb9db4659f1e7fea55fc4d51144d7c.tar.gz git-76e50f7fbccb9db4659f1e7fea55fc4d51144d7c.tar.bz2 | |
fast-export: drop const when storing anonymized values
We store anonymized values as pointers to "const char *", since they are
conceptually const to callers who use them. But they are actually
allocated strings whose memory is owned by the struct.
The ownership mismatch hasn't been a big deal since we never free() them
(they are held until the program ends), but let's switch them to "char *"
in preparation for changing that.
Since most code only accesses them via anonymize_str(), it can continue
to narrow them to "const char *" in its return value.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/fast-export.c')
| -rw-r--r-- | builtin/fast-export.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/builtin/fast-export.c b/builtin/fast-export.c index 78493c6..f422819 100644 --- a/builtin/fast-export.c +++ b/builtin/fast-export.c @@ -110,7 +110,7 @@ static struct decoration idnums; static uint32_t last_idnum; struct anonymized_entry { struct hashmap_entry hash; - const char *anon; + char *anon; const char orig[FLEX_ARRAY]; }; |