summaryrefslogtreecommitdiff
path: root/builtin/config.c
diff options
context:
space:
mode:
authorJeff King <peff@peff.net>2019-01-11 22:17:22 (GMT)
committerJunio C Hamano <gitster@pobox.com>2019-01-12 02:48:59 (GMT)
commit0da0e9268b4825cafb27bb0e07b43fae30bb33da (patch)
treee4b9660b93279f25f2d70351e940f0b5a80bb995 /builtin/config.c
parentd64bb065c0279e523db5270bbcf0ddda74fa9c8f (diff)
downloadgit-0da0e9268b4825cafb27bb0e07b43fae30bb33da.zip
git-0da0e9268b4825cafb27bb0e07b43fae30bb33da.tar.gz
git-0da0e9268b4825cafb27bb0e07b43fae30bb33da.tar.bz2
builtin_diff(): read $GIT_DIFF_OPTS closer to use
The value returned by getenv() is not guaranteed to remain valid across other environment function calls. But in between our call and using the value, we run fill_textconv(), which may do quite a bit of work, including spawning sub-processes. We can make this safer by calling getenv() right before we actually look at its value. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/config.c')
0 files changed, 0 insertions, 0 deletions