path: root/builtin/commit.c
diff options
authorJeff King <>2011-08-18 05:04:56 (GMT)
committerJunio C Hamano <>2011-08-19 22:51:37 (GMT)
commitc659f55b31bb928688afd4ddfd94f8bea978ff1a (patch)
treec8f39adb88e6802bbb8a93f8e38581e489a2a080 /builtin/commit.c
parentdaa0c3d9717624a62ce669252be832db12658ec0 (diff)
config: refactor get_colorbool function
For "git config --get-colorbool", we use a custom callback that looks not only for the key that the user gave us, but also for "diff.color" (for backwards compatibility) and "color.ui" (as a fallback). For the former, we use a custom variable to store the diff.color value. For the latter, though, we store it in the main "git_use_color_default" variable, turning on color.ui for any other parts of git that respect this value. In practice, this doesn't cause any bugs, because git-config runs without caring about git_use_color_default, and then exits. But it crosses module boundaries in an unusual and confusing way, and it makes refactoring color handling harder than it needs to be. Signed-off-by: Jeff King <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'builtin/commit.c')
0 files changed, 0 insertions, 0 deletions