diff options
author | Derrick Stolee <derrickstolee@github.com> | 2022-08-09 13:11:43 (GMT) |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2022-08-10 21:07:37 (GMT) |
commit | e21e663cd1942df29979d3e01f7eacb532727bb7 (patch) | |
tree | 7598ed0a850e002b372a5f88e5abb4a5c305eb31 /builtin/clone.c | |
parent | 59c1752ab6768cb9c380f0a7c9d06af79d183f67 (diff) | |
download | git-e21e663cd1942df29979d3e01f7eacb532727bb7.zip git-e21e663cd1942df29979d3e01f7eacb532727bb7.tar.gz git-e21e663cd1942df29979d3e01f7eacb532727bb7.tar.bz2 |
clone: --bundle-uri cannot be combined with --depth
A previous change added the '--bundle-uri' option, but did not check
if the --depth parameter was included. Since bundles are not compatible
with shallow clones, provide an error message to the user who is
attempting this combination.
I am leaving this as its own change, separate from the one that
implements '--bundle-uri', because this is more of an advisory for the
user. There is nothing wrong with bootstrapping with bundles and then
fetching a shallow clone. However, that is likely going to involve too
much work for the client _and_ the server. The client will download all
of this bundle information containing the full history of the
repository only to ignore most of it. The server will get a shallow
fetch request, but with a list of haves that might cause a more painful
computation of that shallow pack-file.
Reviewed-by: Josh Steadmon <steadmon@google.com>
Signed-off-by: Derrick Stolee <derrickstolee@github.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/clone.c')
-rw-r--r-- | builtin/clone.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/builtin/clone.c b/builtin/clone.c index 4224d56..4463789 100644 --- a/builtin/clone.c +++ b/builtin/clone.c @@ -937,6 +937,9 @@ int cmd_clone(int argc, const char **argv, const char *prefix) option_no_checkout = 1; } + if (bundle_uri && deepen) + die(_("--bundle-uri is incompatible with --depth, --shallow-since, and --shallow-exclude")); + repo_name = argv[0]; path = get_repo_path(repo_name, &is_bundle); |