summaryrefslogtreecommitdiff
path: root/builtin/clone.c
diff options
context:
space:
mode:
authorJunio C Hamano <gitster@pobox.com>2014-06-23 21:27:36 (GMT)
committerJunio C Hamano <gitster@pobox.com>2014-06-23 21:31:35 (GMT)
commit60a5f5fc791d6c133732238736ef0961df600296 (patch)
treeb0d9b77bd01519d3367ab654f2746d082a1d065c /builtin/clone.c
parent34d5217584ee4722d0c0b07ed6c8f1f01ad157c3 (diff)
downloadgit-60a5f5fc791d6c133732238736ef0961df600296.zip
git-60a5f5fc791d6c133732238736ef0961df600296.tar.gz
git-60a5f5fc791d6c133732238736ef0961df600296.tar.bz2
builtin/clone.c: detect a clone starting at a tag correctly
31b808a0 (clone --single: limit the fetch refspec to fetched branch, 2012-09-20) tried to see if the given "branch" to follow is actually a tag at the remote repository by checking with "refs/tags/" but it incorrectly used strstr(3); it is actively wrong to treat a "branch" "refs/heads/refs/tags/foo" and use the logic for the "refs/tags/" ref hierarchy. What the code really wanted to do is to see if it starts with "refs/tags/". Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/clone.c')
-rw-r--r--builtin/clone.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/builtin/clone.c b/builtin/clone.c
index 9b3c04d..545105a 100644
--- a/builtin/clone.c
+++ b/builtin/clone.c
@@ -695,7 +695,7 @@ static void write_refspec_config(const char* src_ref_prefix,
if (option_mirror || !option_bare) {
if (option_single_branch && !option_mirror) {
if (option_branch) {
- if (strstr(our_head_points_at->name, "refs/tags/"))
+ if (starts_with(our_head_points_at->name, "refs/tags/"))
strbuf_addf(&value, "+%s:%s", our_head_points_at->name,
our_head_points_at->name);
else