diff options
| author | Jeff King <peff@peff.net> | 2016-02-22 22:44:25 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2016-02-22 22:51:09 (GMT) |
| commit | b32fa95fd8293ebfecb2b7b6c8d460579318f9fe (patch) | |
| tree | 09af1e6cc980e672e7deefe4bc8f8844a25f14b2 /builtin/clean.c | |
| parent | 850d2fec53ee188bab9e458f77906041ac7f1904 (diff) | |
| download | git-b32fa95fd8293ebfecb2b7b6c8d460579318f9fe.zip git-b32fa95fd8293ebfecb2b7b6c8d460579318f9fe.tar.gz git-b32fa95fd8293ebfecb2b7b6c8d460579318f9fe.tar.bz2 | |
convert trivial cases to ALLOC_ARRAY
Each of these cases can be converted to use ALLOC_ARRAY or
REALLOC_ARRAY, which has two advantages:
1. It automatically checks the array-size multiplication
for overflow.
2. It always uses sizeof(*array) for the element-size,
so that it can never go out of sync with the declared
type of the array.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/clean.c')
| -rw-r--r-- | builtin/clean.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/builtin/clean.c b/builtin/clean.c index 919157b..1f02c82 100644 --- a/builtin/clean.c +++ b/builtin/clean.c @@ -543,7 +543,7 @@ static int *list_and_choose(struct menu_opts *opts, struct menu_stuff *stuff) int eof = 0; int i; - chosen = xmalloc(sizeof(int) * stuff->nr); + ALLOC_ARRAY(chosen, stuff->nr); /* set chosen as uninitialized */ for (i = 0; i < stuff->nr; i++) chosen[i] = -1; |