path: root/builtin/checkout-index.c
diff options
authorJunio C Hamano <>2013-10-23 17:52:42 (GMT)
committerJunio C Hamano <>2013-10-24 21:59:39 (GMT)
commitaf2a651d2ecb3967244c9a44a5813a0cf9977df5 (patch)
treeb2516b618c3bb919a571eded2da72198e1370ed0 /builtin/checkout-index.c
parentfd356f6aa8bb75ebef56fbc61caf7e02517fa6d3 (diff)
checkout_entry(): clarify the use of topath[] parameter
The said function has this signature: extern int checkout_entry(struct cache_entry *ce, const struct checkout *state, char *topath); At first glance, it might appear that the caller of checkout_entry() can specify to which path the contents are written out by the last parameter, and it is tempting to add "const" in front of its type. In reality, however, topath[] is to point at a buffer to store the temporary path generated by the callchain originating from this function, and the temporary path is always short, much shorter than the buffer prepared by its only caller in builtin/checkout-index.c. Document the code a bit to clarify so that future callers know how to use the function better. Noticed-by: Nguyễn Thái Ngọc Duy <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'builtin/checkout-index.c')
1 files changed, 1 insertions, 1 deletions
diff --git a/builtin/checkout-index.c b/builtin/checkout-index.c
index b1feda7..4ed6b23 100644
--- a/builtin/checkout-index.c
+++ b/builtin/checkout-index.c
@@ -14,7 +14,7 @@
static int line_termination = '\n';
static int checkout_stage; /* default to checkout stage0 */
static int to_tempfile;
-static char topath[4][PATH_MAX + 1];
+static char topath[4][TEMPORARY_FILENAME_LENGTH + 1];
static struct checkout state;