path: root/builtin/cat-file.c
diff options
authorJeff King <>2017-09-21 06:23:24 (GMT)
committerJunio C Hamano <>2017-09-22 03:49:55 (GMT)
commitd0e9983980a25e0c398cc03342e5ad22ef85b8a8 (patch)
tree24205669b7ed2d0d34b20e28c4d06e3d93a773fa /builtin/cat-file.c
parent8968b7b0a8bf265a6018682a854002421c2ea84c (diff)
curl_trace(): eliminate switch fallthrough
Our trace handler is called by curl with a curl_infotype variable to interpret its data field. For most types we print the data and then break out of the switch. But for CURLINFO_TEXT, we print data and then fall through to the "default" case, which does the exact same thing (nothing!) that breaking out of the switch would. This is probably a leftover from an early iteration of the patch where the code after the switch _did_ do something interesting that was unique to the non-text case arms. But in its current form, this fallthrough is merely confusing (and causes gcc's -Wimplicit-fallthrough to complain). Let's make CURLINFO_TEXT like the other case arms, and push the default arm to the end where it's more obviously a catch-all. Signed-off-by: Jeff King <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'builtin/cat-file.c')
0 files changed, 0 insertions, 0 deletions