diff options
| author | René Scharfe <l.s.r@web.de> | 2021-08-25 20:16:46 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2021-08-25 21:39:08 (GMT) |
| commit | 66e905b7dd0f4e9dd576be681f30fbaeeb19ec4a (patch) | |
| tree | 4cff22e9d61be87fc5bce6952981e8ba1c7b7127 /builtin/bugreport.c | |
| parent | a7439d0f9dd291e7cc9e6c2dda19cbfdf09b62ee (diff) | |
| download | git-66e905b7dd0f4e9dd576be681f30fbaeeb19ec4a.zip git-66e905b7dd0f4e9dd576be681f30fbaeeb19ec4a.tar.gz git-66e905b7dd0f4e9dd576be681f30fbaeeb19ec4a.tar.bz2 | |
use xopen() to handle fatal open(2) failures
Add and apply a semantic patch for using xopen() instead of calling
open(2) and die() or die_errno() explicitly. This makes the error
messages more consistent and shortens the code.
Signed-off-by: René Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/bugreport.c')
| -rw-r--r-- | builtin/bugreport.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/builtin/bugreport.c b/builtin/bugreport.c index 9915a58..06ed10d 100644 --- a/builtin/bugreport.c +++ b/builtin/bugreport.c @@ -171,10 +171,7 @@ int cmd_bugreport(int argc, const char **argv, const char *prefix) get_populated_hooks(&buffer, !startup_info->have_repository); /* fopen doesn't offer us an O_EXCL alternative, except with glibc. */ - report = open(report_path.buf, O_CREAT | O_EXCL | O_WRONLY, 0666); - - if (report < 0) - die(_("couldn't create a new file at '%s'"), report_path.buf); + report = xopen(report_path.buf, O_CREAT | O_EXCL | O_WRONLY, 0666); if (write_in_full(report, buffer.buf, buffer.len) < 0) die_errno(_("unable to write to %s"), report_path.buf); |