path: root/builtin/bisect--helper.c
diff options
authorMiriam Rubio <>2020-02-17 08:40:28 (GMT)
committerJunio C Hamano <>2020-02-19 17:37:14 (GMT)
commit16538bfd2c429a81a86011f32afa189047afd6e5 (patch)
treea13660900f8d7f8ed621b7c96ba4f5765828169f /builtin/bisect--helper.c
parentd0654dc308b0ba76dd8ed7bbb33c8d8f7aacd783 (diff)
bisect--helper: convert `vocab_*` char pointers to char arrays
Instead of using a pointer that points at a constant string, just give name directly to the constant string; this way, we do not have to allocate a pointer variable in addition to the string we want to use. Let's convert `vocab_bad` and `vocab_good` char pointers to char arrays. Mentored-by: Christian Couder <> Signed-off-by: Miriam Rubio <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'builtin/bisect--helper.c')
1 files changed, 2 insertions, 2 deletions
diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
index 1718df7..36c09b7 100644
--- a/builtin/bisect--helper.c
+++ b/builtin/bisect--helper.c
@@ -52,8 +52,8 @@ static void set_terms(struct bisect_terms *terms, const char *bad,
terms->term_bad = xstrdup(bad);
-static const char *vocab_bad = "bad|new";
-static const char *vocab_good = "good|old";
+static const char vocab_bad[] = "bad|new";
+static const char vocab_good[] = "good|old";
* Check whether the string `term` belongs to the set of strings