summaryrefslogtreecommitdiff
path: root/builtin/add.c
diff options
context:
space:
mode:
authorRené Scharfe <l.s.r@web.de>2021-08-25 20:16:46 (GMT)
committerJunio C Hamano <gitster@pobox.com>2021-08-25 21:39:08 (GMT)
commit66e905b7dd0f4e9dd576be681f30fbaeeb19ec4a (patch)
tree4cff22e9d61be87fc5bce6952981e8ba1c7b7127 /builtin/add.c
parenta7439d0f9dd291e7cc9e6c2dda19cbfdf09b62ee (diff)
downloadgit-66e905b7dd0f4e9dd576be681f30fbaeeb19ec4a.zip
git-66e905b7dd0f4e9dd576be681f30fbaeeb19ec4a.tar.gz
git-66e905b7dd0f4e9dd576be681f30fbaeeb19ec4a.tar.bz2
use xopen() to handle fatal open(2) failures
Add and apply a semantic patch for using xopen() instead of calling open(2) and die() or die_errno() explicitly. This makes the error messages more consistent and shortens the code. Signed-off-by: René Scharfe <l.s.r@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/add.c')
-rw-r--r--builtin/add.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/builtin/add.c b/builtin/add.c
index 09e6845..c37c95b 100644
--- a/builtin/add.c
+++ b/builtin/add.c
@@ -313,9 +313,7 @@ static int edit_patch(int argc, const char **argv, const char *prefix)
rev.diffopt.output_format = DIFF_FORMAT_PATCH;
rev.diffopt.use_color = 0;
rev.diffopt.flags.ignore_dirty_submodules = 1;
- out = open(file, O_CREAT | O_WRONLY | O_TRUNC, 0666);
- if (out < 0)
- die(_("Could not open '%s' for writing."), file);
+ out = xopen(file, O_CREAT | O_WRONLY | O_TRUNC, 0666);
rev.diffopt.file = xfdopen(out, "w");
rev.diffopt.close_file = 1;
if (run_diff_files(&rev, 0))