path: root/builtin-shortlog.c
diff options
authorShawn O. Pearce <>2007-03-07 01:44:17 (GMT)
committerJunio C Hamano <>2007-03-07 18:47:10 (GMT)
commit3a55602eeca4ac8670e8698a7187e18b95683344 (patch)
tree625a8af9c4655ace00b275c3e272c2764db3bcb8 /builtin-shortlog.c
parentff1f99453f1fe2fd9470f6ea268aed5a1839bd09 (diff)
General const correctness fixes
We shouldn't attempt to assign constant strings into char*, as the string is not writable at runtime. Likewise we should always be treating unsigned values as unsigned values, not as signed values. Most of these are very straightforward. The only exception is the (unnecessary) xstrdup/free in builtin-branch.c for the detached head case. Since this is a user-level interactive type program and that particular code path is executed no more than once, I feel that the extra xstrdup call is well worth the easy elimination of this warning. Signed-off-by: Shawn O. Pearce <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'builtin-shortlog.c')
1 files changed, 2 insertions, 2 deletions
diff --git a/builtin-shortlog.c b/builtin-shortlog.c
index 2f71a2a..2d7726e 100644
--- a/builtin-shortlog.c
+++ b/builtin-shortlog.c
@@ -217,13 +217,13 @@ static void get_from_rev(struct rev_info *rev, struct path_list *list)
while ((commit = get_revision(rev)) != NULL) {
- char *author = NULL, *oneline, *buffer;
+ const char *author = NULL, *oneline, *buffer;
int authorlen = authorlen, onelinelen;
/* get author and oneline */
for (buffer = commit->buffer; buffer && *buffer != '\0' &&
*buffer != '\n'; ) {
- char *eol = strchr(buffer, '\n');
+ const char *eol = strchr(buffer, '\n');
if (eol == NULL)
eol = buffer + strlen(buffer);