diff options
| author | Jim Meyering <jim@meyering.net> | 2008-01-04 17:37:41 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2008-01-04 20:28:58 (GMT) |
| commit | 872c930dcb048c1a2b50e6ce881c521dcee15e23 (patch) | |
| tree | ccb4bc3d4d196327513108e59e3aeb76bfeeddbf /builtin-rev-list.c | |
| parent | 95bf4bd4f7280312571e642339f3571310d0d660 (diff) | |
| download | git-872c930dcb048c1a2b50e6ce881c521dcee15e23.zip git-872c930dcb048c1a2b50e6ce881c521dcee15e23.tar.gz git-872c930dcb048c1a2b50e6ce881c521dcee15e23.tar.bz2 | |
Don't access line[-1] for a zero-length "line" from fgets.
A NUL byte at beginning of file, or just after a newline
would provoke an invalid buf[-1] access in a few places.
* builtin-grep.c (cmd_grep): Don't access buf[-1].
* builtin-pack-objects.c (get_object_list): Likewise.
* builtin-rev-list.c (read_revisions_from_stdin): Likewise.
* bundle.c (read_bundle_header): Likewise.
* server-info.c (read_pack_info_file): Likewise.
* transport.c (insert_packed_refs): Likewise.
Signed-off-by: Jim Meyering <meyering@redhat.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin-rev-list.c')
| -rw-r--r-- | builtin-rev-list.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/builtin-rev-list.c b/builtin-rev-list.c index 1cb5f67..de80158 100644 --- a/builtin-rev-list.c +++ b/builtin-rev-list.c @@ -520,7 +520,7 @@ static void read_revisions_from_stdin(struct rev_info *revs) while (fgets(line, sizeof(line), stdin) != NULL) { int len = strlen(line); - if (line[len - 1] == '\n') + if (len && line[len - 1] == '\n') line[--len] = 0; if (!len) break; |