diff options
| author | Junio C Hamano <junkio@cox.net> | 2006-08-28 04:19:39 (GMT) |
|---|---|---|
| committer | Junio C Hamano <junkio@cox.net> | 2006-08-28 04:19:39 (GMT) |
| commit | 4cac42b1324951579036a9d3ac403f5c2c3eeed8 (patch) | |
| tree | 5106e1aff2bd1d90fef4c26550b777dbe1142429 /builtin-rev-list.c | |
| parent | b3c952f8386cebe12fc95227866683bb1cec99a9 (diff) | |
| download | git-4cac42b1324951579036a9d3ac403f5c2c3eeed8.zip git-4cac42b1324951579036a9d3ac403f5c2c3eeed8.tar.gz git-4cac42b1324951579036a9d3ac403f5c2c3eeed8.tar.bz2 | |
free(NULL) is perfectly valid.
Jonas noticed some places say "if (X) free(X)" which is totally
unnecessary.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Diffstat (limited to 'builtin-rev-list.c')
| -rw-r--r-- | builtin-rev-list.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/builtin-rev-list.c b/builtin-rev-list.c index bc48a3e..7f3e1fc 100644 --- a/builtin-rev-list.c +++ b/builtin-rev-list.c @@ -93,10 +93,8 @@ static void show_commit(struct commit *commit) free_commit_list(commit->parents); commit->parents = NULL; } - if (commit->buffer) { - free(commit->buffer); - commit->buffer = NULL; - } + free(commit->buffer); + commit->buffer = NULL; } static void process_blob(struct blob *blob, |