path: root/builtin-rev-list.c
diff options
authorTheodore Ts'o <>2007-06-29 17:40:46 (GMT)
committerJunio C Hamano <>2007-07-01 03:16:12 (GMT)
commit06f59e9f5daa06fc4bd51cf4c508b3edd3ed514a (patch)
tree589caae1830bf51eb10f1022cdb0a8f5fa97ba07 /builtin-rev-list.c
parentee36856d8c8c1f8d53650a70d8f61561fb65ba38 (diff)
Don't fflush(stdout) when it's not helpful
This patch arose from a discussion started by Jim Meyering's patch whose intention was to provide better diagnostics for failed writes. Linus proposed a better way to do things, which also had the added benefit that adding a fflush() to git-log-* operations and incremental git-blame operations could improve interactive respose time feel, at the cost of making things a bit slower when we aren't piping the output to a downstream program. This patch skips the fflush() calls when stdout is a regular file, or if the environment variable GIT_FLUSH is set to "0". This latter can speed up a command such as: GIT_FLUSH=0 strace -c -f -e write time git-rev-list HEAD | wc -l a tiny amount. Signed-off-by: "Theodore Ts'o" <> Acked-by: Linus Torvalds <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'builtin-rev-list.c')
1 files changed, 1 insertions, 1 deletions
diff --git a/builtin-rev-list.c b/builtin-rev-list.c
index 813aadf..86db8b0 100644
--- a/builtin-rev-list.c
+++ b/builtin-rev-list.c
@@ -100,7 +100,7 @@ static void show_commit(struct commit *commit)
printf("%s%c", buf, hdr_termination);
- fflush(stdout);
+ maybe_flush_or_die(stdout, "stdout");
if (commit->parents) {
commit->parents = NULL;