path: root/builtin-diff.c
diff options
authorJunio C Hamano <>2006-07-08 08:05:16 (GMT)
committerJunio C Hamano <>2006-07-08 10:11:01 (GMT)
commit83ad63cfebdf652ff7c7b255d700d8b12c756913 (patch)
treed23227484e77cc05bd534675554279f174cf7642 /builtin-diff.c
parentb53766483ff14f73be954617349b18ea56c3187a (diff)
diff: do not use configuration magic at the core-level
The Porcelainish has become so much usable as the UI that there is not much reason people should be using the core programs by hand anymore. At this point we are better off making the behaviour of the core programs predictable by keeping them unaffected by the configuration variables. Otherwise they will become very hard to use as reliable building blocks. For example, "git-commit -a" internally uses git-diff-files to figure out the set of paths that need to be updated in the index, and we should never allow diff.renames that happens to be in the configuration to interfere (or slow down the process). The UI level configuration such as showing renamed diff and coloring are still honored by the Porcelainish ("git log" family and "git diff"), but not by the core anymore. Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'builtin-diff.c')
1 files changed, 1 insertions, 1 deletions
diff --git a/builtin-diff.c b/builtin-diff.c
index d520c7c..1df531b 100644
--- a/builtin-diff.c
+++ b/builtin-diff.c
@@ -250,7 +250,7 @@ int cmd_diff(int argc, const char **argv, char **envp)
* Other cases are errors.
- git_config(git_diff_config);
+ git_config(git_diff_ui_config);
argc = setup_revisions(argc, argv, &rev, NULL);