path: root/bisect.h
diff options
authorChristian Couder <>2009-04-06 20:28:00 (GMT)
committerJunio C Hamano <>2009-04-08 05:12:41 (GMT)
commitd797257eb280b67dd1f7153a66b03453c0fb927a (patch)
treeebb76167611556b8f96f2363440a6793907d9bb2 /bisect.h
parent11c211fa06fc396e8ee8132ef83e2f2763ff6976 (diff)
rev-list: remove last static vars used in "show_commit"
This patch removes the last static variables that were used in the "show_commit" function. To do that, we create a new "rev_list_info" struct that we will pass in the "void *data" argument to "show_commit". This means that we have to change the first argument to "show_bisect_vars" too. While at it, we also remove a "struct commit_list *list" variable in "cmd_rev_list" that is not really needed. Signed-off-by: Christian Couder <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'bisect.h')
1 files changed, 8 insertions, 6 deletions
diff --git a/bisect.h b/bisect.h
index f5d1067..b1c334d 100644
--- a/bisect.h
+++ b/bisect.h
@@ -14,12 +14,14 @@ extern struct commit_list *filter_skipped(struct commit_list *list,
#define BISECT_SHOW_TRIED (1<<1)
- * The flag BISECT_SHOW_ALL should not be set if this function is called
- * from outside "builtin-rev-list.c" as otherwise it would use
- * static "revs" from this file.
- */
-extern int show_bisect_vars(struct rev_info *revs, int reaches, int all,
+struct rev_list_info {
+ struct rev_info *revs;
+ int show_timestamp;
+ int hdr_termination;
+ const char *header_prefix;
+extern int show_bisect_vars(struct rev_list_info *info, int reaches, int all,
int flags);
extern int bisect_next_vars(const char *prefix);