summaryrefslogtreecommitdiff
path: root/bisect.h
diff options
context:
space:
mode:
authorMiriam Rubio <mirucam@gmail.com>2020-02-17 08:40:32 (GMT)
committerJunio C Hamano <gitster@pobox.com>2020-02-19 17:37:14 (GMT)
commit680e8a01e57cd383048bf4e7d9668ce715d6d649 (patch)
tree8f067a0f2a5a9a6073b205f393cc21adcfc29dae /bisect.h
parentbfacfce7d94951fe5b4e70bc2431dae5506b474b (diff)
downloadgit-680e8a01e57cd383048bf4e7d9668ce715d6d649.zip
git-680e8a01e57cd383048bf4e7d9668ce715d6d649.tar.gz
git-680e8a01e57cd383048bf4e7d9668ce715d6d649.tar.bz2
bisect: add enum to represent bisect returning codes
Since we want to get rid of git-bisect.sh, it would be necessary to convert those exit() calls to return statements so that errors can be reported. Create an enum called `bisect_error` with the bisecting return codes to use in `bisect.c` libification process. Change bisect_next_all() to make it return this enum. Mentored-by: Christian Couder <chriscool@tuxfamily.org> Signed-off-by: Miriam Rubio <mirucam@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'bisect.h')
-rw-r--r--bisect.h14
1 files changed, 13 insertions, 1 deletions
diff --git a/bisect.h b/bisect.h
index 4e69a11..c921ead 100644
--- a/bisect.h
+++ b/bisect.h
@@ -31,7 +31,19 @@ struct rev_list_info {
const char *header_prefix;
};
-int bisect_next_all(struct repository *r,
+/*
+ * enum bisect_error represents the following return codes:
+ * BISECT_OK: success code. Internally, it means that next
+ * commit has been found (and possibly checked out) and it
+ * should be tested.
+ * BISECT_FAILED error code: default error code.
+ */
+enum bisect_error {
+ BISECT_OK = 0,
+ BISECT_FAILED = -1
+};
+
+enum bisect_error bisect_next_all(struct repository *r,
const char *prefix,
int no_checkout);