path: root/attr.c
diff options
authorSaurav Sachidanand <>2016-03-01 17:02:59 (GMT)
committerJunio C Hamano <>2016-03-01 18:20:22 (GMT)
commitf870899864e077a54776af838c6476d5850cfaaf (patch)
tree0b9482b7e660103342c9464c47167a0b7c3709fa /attr.c
parenta2558fb8e1e387b630312311e1d22c95663da5d0 (diff)
dir: store EXC_FLAG_* values in unsigned integers
The values defined by the macro EXC_FLAG_* (1, 4, 8, 16) are stored in fields of the structs "pattern" and "exclude", some functions arguments and a local variable. None of these uses its most significant bit in any special way and there is no good reason to use a signed integer for them. And while we're at it, document "flags" of "exclude" to explicitly state the values it's supposed to take on. Signed-off-by: Saurav Sachidanand <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'attr.c')
1 files changed, 1 insertions, 1 deletions
diff --git a/attr.c b/attr.c
index 8f2ac6c..e273f7a 100644
--- a/attr.c
+++ b/attr.c
@@ -124,7 +124,7 @@ struct pattern {
const char *pattern;
int patternlen;
int nowildcardlen;
- int flags; /* EXC_FLAG_* */
+ unsigned flags; /* EXC_FLAG_* */