path: root/archive.h
diff options
authorJosh Steadmon <>2018-10-25 20:32:14 (GMT)
committerJunio C Hamano <>2018-10-26 01:17:59 (GMT)
commit00436bf1b1c2a8fe6cf5d2c2457d419d683042f4 (patch)
tree8ebc2b31bba3bec7673287db8b4b96257df8635f /archive.h
parentc4df23f7927d8d00e666a3c8d1b3375f1dc8a3c1 (diff)
archive: initialize archivers earlier
Initialize archivers as soon as possible when running git-archive. Various non-obvious behavior depends on having the archivers initialized, such as determining the desired archival format from the provided filename. Since 08716b3c11 ("archive: refactor file extension format-guessing", 2011-06-21), archive_format_from_filename() has used the registered archivers to match filenames (provided via --output) to archival formats. However, when git-archive is executed with --remote, format detection happens before the archivers have been registered. This causes archives from remotes to always be generated as TAR files, regardless of the actual filename (unless an explicit --format is provided). This patch fixes that behavior; archival format is determined properly from the output filename, even when --remote is used. Helped-by: Jeff King <> Signed-off-by: Josh Steadmon <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'archive.h')
1 files changed, 1 insertions, 0 deletions
diff --git a/archive.h b/archive.h
index d4f97a0..21ac010 100644
--- a/archive.h
+++ b/archive.h
@@ -43,6 +43,7 @@ extern void register_archiver(struct archiver *);
extern void init_tar_archiver(void);
extern void init_zip_archiver(void);
+extern void init_archivers(void);
typedef int (*write_archive_entry_fn_t)(struct archiver_args *args,
const struct object_id *oid,