diff options
| author | Johannes Schindelin <johannes.schindelin@gmx.de> | 2017-04-26 19:29:31 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2017-04-27 04:07:39 (GMT) |
| commit | dddbad728c93280fe54ef86699b6d70e2aab44d1 (patch) | |
| tree | c2a48100bf8597f0771e6737fda19e7255c737dc /archive-tar.c | |
| parent | cb71f8bdb5a105cd5b66142b887989d9addc82d0 (diff) | |
| download | git-dddbad728c93280fe54ef86699b6d70e2aab44d1.zip git-dddbad728c93280fe54ef86699b6d70e2aab44d1.tar.gz git-dddbad728c93280fe54ef86699b6d70e2aab44d1.tar.bz2 | |
timestamp_t: a new data type for timestamps
Git's source code assumes that unsigned long is at least as precise as
time_t. Which is incorrect, and causes a lot of problems, in particular
where unsigned long is only 32-bit (notably on Windows, even in 64-bit
versions).
So let's just use a more appropriate data type instead. In preparation
for this, we introduce the new `timestamp_t` data type.
By necessity, this is a very, very large patch, as it has to replace all
timestamps' data type in one go.
As we will use a data type that is not necessarily identical to `time_t`,
we need to be very careful to use `time_t` whenever we interact with the
system functions, and `timestamp_t` everywhere else.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'archive-tar.c')
| -rw-r--r-- | archive-tar.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/archive-tar.c b/archive-tar.c index 380e3ae..319a5b1 100644 --- a/archive-tar.c +++ b/archive-tar.c @@ -27,9 +27,12 @@ static int write_tar_filter_archive(const struct archiver *ar, */ #if ULONG_MAX == 0xFFFFFFFF #define USTAR_MAX_SIZE ULONG_MAX -#define USTAR_MAX_MTIME ULONG_MAX #else -#define USTAR_MAX_SIZE 077777777777UL +#define USTAR_MAX_SIZE 077777777777ULL +#endif +#if TIME_MAX == 0xFFFFFFFF +#define USTAR_MAX_MTIME TIME_MAX +#else #define USTAR_MAX_MTIME 077777777777UL #endif |