path: root/apply.c
diff options
authorbrian m. carlson <>2019-09-02 22:39:44 (GMT)
committerJunio C Hamano <>2019-09-03 22:16:18 (GMT)
commit2c65d90f7579a0e2a6460eebce44795587e87043 (patch)
tree6b51679f6aaf76f1dd2a3eda6d2bdc6ef75928bb /apply.c
parentce17feb1b3ecfb0344af9b9111a4b4d313d51d7a (diff)
am: reload .gitattributes after patching it
When applying multiple patches with git am, or when rebasing using the am backend, it's possible that one of our patches has updated a gitattributes file. Currently, we cache this information, so if a file in a subsequent patch has attributes applied, the file will be written out with the attributes in place as of the time we started the rebase or am operation, not with the attributes applied by the previous patch. This problem does not occur when using the -m or -i flags to rebase. To ensure we write the correct data into the working tree, expire the cache after each patch that touches a path ending in ".gitattributes". Since we load these attributes in multiple separate files, we must expire them accordingly. Verify that both the am and rebase code paths work correctly, including the conflict marker size with am -3. Signed-off-by: brian m. carlson <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'apply.c')
1 files changed, 11 insertions, 0 deletions
diff --git a/apply.c b/apply.c
index 4992eca..2e11438 100644
--- a/apply.c
+++ b/apply.c
@@ -4663,6 +4663,7 @@ static int apply_patch(struct apply_state *state,
struct patch *list = NULL, **listp = &list;
int skipped_patch = 0;
int res = 0;
+ int flush_attributes = 0;
state->patch_input_file = filename;
if (read_patch_file(&buf, fd) < 0)
@@ -4690,6 +4691,14 @@ static int apply_patch(struct apply_state *state,
patch_stats(state, patch);
*listp = patch;
listp = &patch->next;
+ if ((patch->new_name &&
+ ends_with_path_components(patch->new_name,
+ (patch->old_name &&
+ ends_with_path_components(patch->old_name,
+ flush_attributes = 1;
else {
if (state->apply_verbosity > verbosity_normal)
@@ -4766,6 +4775,8 @@ static int apply_patch(struct apply_state *state,
if (state->summary && state->apply_verbosity > verbosity_silent)
+ if (flush_attributes)
+ reset_parsed_attributes();