path: root/alloc.c
diff options
authorAbhishek Kumar <>2020-06-17 09:14:08 (GMT)
committerJunio C Hamano <>2020-06-17 21:37:14 (GMT)
commit6da43d937ca96d277556fa92c5a664fb1cbcc8ac (patch)
treece884f3ed784156350127e7fcb2bddcf49ef905a /alloc.c
parenteebb51ba8cab97c0b3f3f18eaab7796803b8494b (diff)
object: drop parsed_object_pool->commit_count
14ba97f8 (alloc: allow arbitrary repositories for alloc functions, 2018-05-15) introduced parsed_object_pool->commit_count to keep count of commits per repository and was used to assign commit->index. However, commit-slab code requires commit->index values to be unique and a global count would be correct, rather than a per-repo count. Let's introduce a static counter variable, `parsed_commits_count` to keep track of parsed commits so far. As commit_count has no use anymore, let's also drop it from the struct. Signed-off-by: Abhishek Kumar <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'alloc.c')
1 files changed, 11 insertions, 5 deletions
diff --git a/alloc.c b/alloc.c
index 1c64c4d..99fa934 100644
--- a/alloc.c
+++ b/alloc.c
@@ -99,15 +99,21 @@ void *alloc_object_node(struct repository *r)
return obj;
-static unsigned int alloc_commit_index(struct repository *r)
+ * The returned count is to be used as an index into commit slabs,
+ * that are *NOT* maintained per repository, and that is why a single
+ * global counter is used.
+ */
+static unsigned int alloc_commit_index(void)
- return r->parsed_objects->commit_count++;
+ static unsigned int parsed_commits_count;
+ return parsed_commits_count++;
-void init_commit_node(struct repository *r, struct commit *c)
+void init_commit_node(struct commit *c)
c->object.type = OBJ_COMMIT;
- c->index = alloc_commit_index(r);
+ c->index = alloc_commit_index();
c->graph_pos = COMMIT_NOT_FROM_GRAPH;
@@ -115,7 +121,7 @@ void init_commit_node(struct repository *r, struct commit *c)
void *alloc_commit_node(struct repository *r)
struct commit *c = alloc_node(r->parsed_objects->commit_state, sizeof(struct commit));
- init_commit_node(r, c);
+ init_commit_node(c);
return c;