path: root/add-interactive.h
diff options
authorJohannes Schindelin <>2019-11-13 12:40:57 (GMT)
committerJunio C Hamano <>2019-11-14 02:10:04 (GMT)
commitf83dff60a7880f1abfc3dc3c6b8e2972c4889da5 (patch)
tree87209a9f4882e988bab1b580b049375052970f07 /add-interactive.h
parentda72936f544fec5a335e66432610e4cef4430991 (diff)
Start to implement a built-in version of `git add --interactive`
Unlike previous conversions to C, where we started with a built-in helper, we start this conversion by adding an interception in the `run_add_interactive()` function when the new opt-in `add.interactive.useBuiltin` config knob is turned on (or the corresponding environment variable `GIT_TEST_ADD_I_USE_BUILTIN`), and calling the new internal API function `run_add_i()` that is implemented directly in libgit.a. At this point, the built-in version of `git add -i` only states that it cannot do anything yet. In subsequent patches/patch series, the `run_add_i()` function will gain more and more functionality, until it is feature complete. The whole arc of the conversion can be found in the PRs #170-175 at The "--helper approach" can unfortunately not be used here: on Windows we face the very specific problem that a `system()` call in Perl seems to close `stdin` in the parent process when the spawned process consumes even one character from `stdin`. Which prevents us from implementing the main loop in C and still trying to hand off to the Perl script. The very real downside of the approach we have to take here is that the test suite won't pass with `GIT_TEST_ADD_I_USE_BUILTIN=true` until the conversion is complete (the `--helper` approach would have let it pass, even at each of the incremental conversion steps). Signed-off-by: Johannes Schindelin <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'add-interactive.h')
1 files changed, 8 insertions, 0 deletions
diff --git a/add-interactive.h b/add-interactive.h
new file mode 100644
index 0000000..7043b87
--- /dev/null
+++ b/add-interactive.h
@@ -0,0 +1,8 @@
+struct repository;
+struct pathspec;
+int run_add_i(struct repository *r, const struct pathspec *ps);