summaryrefslogtreecommitdiff
path: root/Makefile
diff options
context:
space:
mode:
authorArnout Engelen <arnouten@bzzt.net>2010-12-18 21:28:00 (GMT)
committerJunio C Hamano <gitster@pobox.com>2010-12-22 03:51:17 (GMT)
commit6cf6bb3e47ac2f667fa0b27a4222e903ff6fb77c (patch)
tree6f85fb8abadf0e819712c74361b52852858d543a /Makefile
parent853563d7344ee532aa56f8a9aabcfdfb5c4fe2c3 (diff)
downloadgit-6cf6bb3e47ac2f667fa0b27a4222e903ff6fb77c.zip
git-6cf6bb3e47ac2f667fa0b27a4222e903ff6fb77c.tar.gz
git-6cf6bb3e47ac2f667fa0b27a4222e903ff6fb77c.tar.bz2
Improve error messages when temporary file creation fails
Before, when creating a temporary file failed, a generic 'Unable to create temporary file' message was printed. In some cases this could lead to confusion as to which directory should be checked for correct permissions etc. This patch adds the template for the temporary filename to the error message, converting it to an absolute path if needed. A test verifies that the template is indeed printed when pointing to a nonexistent or unwritable directory. A copy of the original template is made in case mkstemp clears the template. Signed-off-by: Arnout Engelen <arnouten@bzzt.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'Makefile')
-rw-r--r--Makefile1
1 files changed, 1 insertions, 0 deletions
diff --git a/Makefile b/Makefile
index 57d9c65..03a51cb 100644
--- a/Makefile
+++ b/Makefile
@@ -434,6 +434,7 @@ TEST_PROGRAMS_NEED_X += test-string-pool
TEST_PROGRAMS_NEED_X += test-svn-fe
TEST_PROGRAMS_NEED_X += test-treap
TEST_PROGRAMS_NEED_X += test-index-version
+TEST_PROGRAMS_NEED_X += test-mktemp
TEST_PROGRAMS = $(patsubst %,%$X,$(TEST_PROGRAMS_NEED_X))