path: root/Documentation
diff options
authorJakub Narebski <>2008-06-02 09:54:41 (GMT)
committerJunio C Hamano <>2008-06-03 03:36:02 (GMT)
commitf70dda250e33dd17f6fdff17d15287391d8b0952 (patch)
tree31628ed99028569a9d0ffbf9972fa53e07e32114 /Documentation
parent3db4723ead0f141540118f622dedac5106b07a8e (diff)
gitweb: Fix "next" link on bottom of page
Fix search form generation to not modify $cgi->param(...)'s. In git_header_html() we used to use $cgi->hidden(-name => "a") etc. to generate hidden fields; unfortunately to use this form it is required to modify $cgi->param("a") etc., which makes href(-replay,...) use wrong replay values. This for example made the "next" link on the bottom of the page has a=search instead of a=$action, and thus fails to get you to the next page. Because in CGI the value of a hidden field is "sticky", there is no way to modify it short of modifying $cgi->param(...). Therefore it got replaced by generating <input type="hidden" ...> element [semi] directly. Alternate solution would be for href(-replay,...) to use values saved in global variables, such as $action etc., instead of (re)reading them from $cgi->param($symbol). The bad link was reported by Kai Blin through Reported-by: Kai Blin <> Signed-off-by: Jakub Narebski <> Tested-by: Gerrit Pape <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'Documentation')
0 files changed, 0 insertions, 0 deletions