path: root/Documentation/technical
diff options
authorJens Lehmann <>2013-11-07 14:33:43 (GMT)
committerJunio C Hamano <>2013-11-07 18:28:26 (GMT)
commitbc8d6b9b904350c72017a3c92fdacbfba5b1be3f (patch)
tree2dc4048fa383ddaf597cd6bb0120377bf4e6b34a /Documentation/technical
parent2141c474d0dd7cddf224780644e64bc7fa493f07 (diff)
submodule: don't access the .gitmodules cache entry after removing it
Commit 5fee995244e introduced the stage_updated_gitmodules() function to add submodule configuration updates to the index. It assumed that even after calling remove_cache_entry_at() the same cache entry would still be valid. This was true in the old days, as cache entries could never be freed, but that is not so sure in the present as there is ongoing work to free removed cache entries, which makes this code segfault. Fix that by calling add_file_to_cache() instead of open coding it. Also remove the "could not find .gitmodules in index" warning, as that won't happen in regular use cases (and by then just silently adding it to the index we do the right thing). Thanks-to: Karsten Blees <> Signed-off-by: Jens Lehmann <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'Documentation/technical')
0 files changed, 0 insertions, 0 deletions