summaryrefslogtreecommitdiff
path: root/Documentation/git-update-index.txt
diff options
context:
space:
mode:
authorNguyễn Thái Ngọc Duy <pclouds@gmail.com>2018-02-07 09:21:40 (GMT)
committerJunio C Hamano <gitster@pobox.com>2018-02-07 20:27:02 (GMT)
commit0cacebf099dd6467845419f212acdcfe5f8d923f (patch)
tree0495def2eef78e004145945ec0a1dee7a66731d1 /Documentation/git-update-index.txt
parentb6731550749c7326f0dcf26211e7c2e55de00e28 (diff)
downloadgit-0cacebf099dd6467845419f212acdcfe5f8d923f.zip
git-0cacebf099dd6467845419f212acdcfe5f8d923f.tar.gz
git-0cacebf099dd6467845419f212acdcfe5f8d923f.tar.bz2
dir.c: ignore paths containing .git when invalidating untracked cache
read_directory() code ignores all paths named ".git" even if it's not a valid git repository. See treat_path() for details. Since ".git" is basically invisible to read_directory(), when we are asked to invalidate a path that contains ".git", we can safely ignore it because the slow path would not consider it anyway. This helps when fsmonitor is used and we have a real ".git" repo at worktree top. Occasionally .git/index will be updated and if the fsmonitor hook does not filter it, untracked cache is asked to invalidate the path ".git/index". Without this patch, we invalidate the root directory unncessarily, which: - makes read_directory() fall back to slow path for root directory (slower) - makes the index dirty (because UNTR extension is updated). Depending on the index size, writing it down could also be slow. A note about the new "safe_path" knob. Since this new check could be relatively expensive, avoid it when we know it's not needed. If the path comes from the index, it can't contain ".git". If it does contain, we may be screwed up at many more levels, not just this one. Noticed-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'Documentation/git-update-index.txt')
0 files changed, 0 insertions, 0 deletions