path: root/Documentation/SubmittingPatches
diff options
authorJunio C Hamano <>2007-05-22 01:42:35 (GMT)
committerJunio C Hamano <>2007-05-22 01:42:35 (GMT)
commitf95c6780c244e90abf87222126ad3b4bb18a504e (patch)
treeede18dbb8b33e330f3837209a489f7737df2dc25 /Documentation/SubmittingPatches
parent7df6ddf51ea71d81874ecfa34f670f50a3d45103 (diff)
parent0ba956d331e4c14fb1600a62044492c6c27af71a (diff)
Merge branch 'maint-1.5.1' into maint
* maint-1.5.1: git-status: respect core.excludesFile SubmittingPatches: mention older C compiler compatibility git-daemon: don't ignore pid-file write failure
Diffstat (limited to 'Documentation/SubmittingPatches')
1 files changed, 13 insertions, 0 deletions
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index 6a4da2d..b94d9a8 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -65,6 +65,19 @@ in templates/hooks--pre-commit. To help ensure this does not happen,
run git diff --check on your changes before you commit.
+(1a) Try to be nice to older C compilers
+We try to support wide range of C compilers to compile
+git with. That means that you should not use C99 initializers, even
+if a lot of compilers grok it.
+Also, variables have to be declared at the beginning of the block
+(you can check this with gcc, using the -Wdeclaration-after-statement
+Another thing: NULL pointers shall be written as NULL, not as 0.
(2) Generate your patch using git tools out of your commits.
git based diff tools (git, Cogito, and StGIT included) generate