summaryrefslogtreecommitdiff
path: root/Documentation/SubmittingPatches
diff options
context:
space:
mode:
authorJohannes Schindelin <Johannes.Schindelin@gmx.de>2007-05-21 12:48:49 (GMT)
committerJunio C Hamano <junkio@cox.net>2007-05-22 01:35:37 (GMT)
commit243bfd33997484ee8ea2450f1910306f7138193b (patch)
tree92e9710a88130f831dc47d501160eaafd7ab4ec1 /Documentation/SubmittingPatches
parentbc4e7d035840539eb5aa13ab3d51ab43cc2c1b50 (diff)
downloadgit-243bfd33997484ee8ea2450f1910306f7138193b.zip
git-243bfd33997484ee8ea2450f1910306f7138193b.tar.gz
git-243bfd33997484ee8ea2450f1910306f7138193b.tar.bz2
SubmittingPatches: mention older C compiler compatibility
We do not appreciate C99 initializers, declarations after statements, or "0" instead of "NULL". Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de> Signed-off-by: Junio C Hamano <junkio@cox.net>
Diffstat (limited to 'Documentation/SubmittingPatches')
-rw-r--r--Documentation/SubmittingPatches13
1 files changed, 13 insertions, 0 deletions
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index 8cf5093..1ba9041 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -62,6 +62,19 @@ in templates/hooks--pre-commit. To help ensure this does not happen,
run git diff --check on your changes before you commit.
+(1a) Try to be nice to older C compilers
+
+We try to support wide range of C compilers to compile
+git with. That means that you should not use C99 initializers, even
+if a lot of compilers grok it.
+
+Also, variables have to be declared at the beginning of the block
+(you can check this with gcc, using the -Wdeclaration-after-statement
+option).
+
+Another thing: NULL pointers shall be written as NULL, not as 0.
+
+
(2) Generate your patch using git tools out of your commits.
git based diff tools (git, Cogito, and StGIT included) generate