summaryrefslogtreecommitdiff
path: root/Documentation/CodingGuidelines
diff options
context:
space:
mode:
authorJunio C Hamano <gitster@pobox.com>2020-05-08 21:25:07 (GMT)
committerJunio C Hamano <gitster@pobox.com>2020-05-08 21:25:07 (GMT)
commit6d4bf5813cd2c1a3b93fd4f0b231733f82133cce (patch)
treec6a42769e8a2b0a3af91e89d4934c5ce0b94b458 /Documentation/CodingGuidelines
parente9acbd68366ae26834a1f8d0801647a7e6de9500 (diff)
parent32b5fe7f0e2cb798954b3e01b990bc140706e191 (diff)
downloadgit-6d4bf5813cd2c1a3b93fd4f0b231733f82133cce.zip
git-6d4bf5813cd2c1a3b93fd4f0b231733f82133cce.tar.gz
git-6d4bf5813cd2c1a3b93fd4f0b231733f82133cce.tar.bz2
Merge branch 'jk/arith-expansion-coding-guidelines'
The coding guideline for shell scripts instructed to refer to a variable with dollar-sign inside arithmetic expansion to work around a bug in old versions of dash, which is a thing of the past. Now we are not forbidden from writing $((var+1)). * jk/arith-expansion-coding-guidelines: CodingGuidelines: drop arithmetic expansion advice to use "$x"
Diffstat (limited to 'Documentation/CodingGuidelines')
-rw-r--r--Documentation/CodingGuidelines4
1 files changed, 0 insertions, 4 deletions
diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines
index 390ceec..a89e8dc 100644
--- a/Documentation/CodingGuidelines
+++ b/Documentation/CodingGuidelines
@@ -95,10 +95,6 @@ For shell scripts specifically (not exhaustive):
- We use Arithmetic Expansion $(( ... )).
- - Inside Arithmetic Expansion, spell shell variables with $ in front
- of them, as some shells do not grok $((x)) while accepting $(($x))
- just fine (e.g. dash older than 0.5.4).
-
- We do not use Process Substitution <(list) or >(list).
- Do not write control structures on a single line with semicolon.