summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTodd Zullinger <tmz@pobox.com>2009-02-08 23:12:43 (GMT)
committerJunio C Hamano <gitster@pobox.com>2009-02-09 08:06:36 (GMT)
commitf6b98e46bdf64454d7c6ab76d617237118799d7b (patch)
tree633b22580dbfff3c8744f30b03276cfb2de55066
parentdf487baa30924a36ade38ada4f77379236dcce0f (diff)
downloadgit-f6b98e46bdf64454d7c6ab76d617237118799d7b.zip
git-f6b98e46bdf64454d7c6ab76d617237118799d7b.tar.gz
git-f6b98e46bdf64454d7c6ab76d617237118799d7b.tar.bz2
git-web--browse: Fix check for /bin/start
The previous check in git-web--browse for /bin/start used test -n /bin/start, which was always true. This lead to "start" being tried first in the browser list. On systems with upstart installed, "start" exists and might be in the PATH, but it makes a poor choice for a web browser. Instead, test that /bin/start exists and is executable. Signed-off-by: Todd Zullinger <tmz@pobox.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rwxr-xr-xgit-web--browse.sh2
1 files changed, 1 insertions, 1 deletions
diff --git a/git-web--browse.sh b/git-web--browse.sh
index 78d236b..7ed0fad 100755
--- a/git-web--browse.sh
+++ b/git-web--browse.sh
@@ -115,7 +115,7 @@ if test -z "$browser" ; then
browser_candidates="open $browser_candidates"
fi
# /bin/start indicates MinGW
- if test -n /bin/start; then
+ if test -x /bin/start; then
browser_candidates="start $browser_candidates"
fi