summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Rientjes <rientjes@google.com>2006-08-14 20:19:15 (GMT)
committerJunio C Hamano <junkio@cox.net>2006-08-15 01:43:49 (GMT)
commiteddd1c8cefa596abbb81ac5a0af21ba104033b3d (patch)
tree49158d769f65357b15da67f4448c18e9bc3672cf
parenta976b0a5933f37e7e8a1829703705268bc829794 (diff)
downloadgit-eddd1c8cefa596abbb81ac5a0af21ba104033b3d.zip
git-eddd1c8cefa596abbb81ac5a0af21ba104033b3d.tar.gz
git-eddd1c8cefa596abbb81ac5a0af21ba104033b3d.tar.bz2
Make pprint_tag void and cleans up call in cmd_cat_file.
Signed-off-by: David Rientjes <rientjes@google.com> Signed-off-by: Junio C Hamano <junkio@cox.net>
-rw-r--r--builtin-cat-file.c9
1 files changed, 5 insertions, 4 deletions
diff --git a/builtin-cat-file.c b/builtin-cat-file.c
index 814fb07..df009ad 100644
--- a/builtin-cat-file.c
+++ b/builtin-cat-file.c
@@ -26,7 +26,7 @@ static void flush_buffer(const char *buf, unsigned long size)
}
}
-static int pprint_tag(const unsigned char *sha1, const char *buf, unsigned long size)
+static void pprint_tag(const unsigned char *sha1, const char *buf, unsigned long size)
{
/* the parser in tag.c is useless here. */
const char *endp = buf + size;
@@ -91,7 +91,6 @@ static int pprint_tag(const unsigned char *sha1, const char *buf, unsigned long
*/
if (cp < endp)
flush_buffer(cp, endp - cp);
- return 0;
}
int cmd_cat_file(int argc, const char **argv, const char *prefix)
@@ -145,8 +144,10 @@ int cmd_cat_file(int argc, const char **argv, const char *prefix)
buf = read_sha1_file(sha1, type, &size);
if (!buf)
die("Cannot read object %s", argv[2]);
- if (!strcmp(type, tag_type))
- return pprint_tag(sha1, buf, size);
+ if (!strcmp(type, tag_type)) {
+ pprint_tag(sha1, buf, size);
+ return 0;
+ }
/* otherwise just spit out the data */
break;