diff options
| author | Uwe Kleine-König <ukleinek@informatik.uni-freiburg.de> | 2007-03-22 16:18:08 (GMT) |
|---|---|---|
| committer | Junio C Hamano <junkio@cox.net> | 2007-03-23 08:48:29 (GMT) |
| commit | cc65343a8436896f4c78f5f802595870784df454 (patch) | |
| tree | 62a06bb840252ad240bd93bc5186b845c0b0417f | |
| parent | 3007a78033fec09b97ff1ca816a2d23c292dd956 (diff) | |
| download | git-cc65343a8436896f4c78f5f802595870784df454.zip git-cc65343a8436896f4c78f5f802595870784df454.tar.gz git-cc65343a8436896f4c78f5f802595870784df454.tar.bz2 | |
Bisect: convert revs given to good and bad to commits
Without this the rev could be (e.g.) a tag and then the condition to end the
bisect might fail and you have to check the already known to be bad revision
once more.
Signed-off-by: Uwe Kleine-König <ukleinek@informatik.uni-freiburg.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
| -rwxr-xr-x | git-bisect.sh | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/git-bisect.sh b/git-bisect.sh index b1c3a6b..dbce0df 100755 --- a/git-bisect.sh +++ b/git-bisect.sh @@ -85,7 +85,7 @@ bisect_bad() { 0) rev=$(git-rev-parse --verify HEAD) ;; 1) - rev=$(git-rev-parse --verify "$1") ;; + rev=$(git-rev-parse --verify "$1^{commit}") ;; *) usage ;; esac || exit @@ -104,7 +104,7 @@ bisect_good() { esac for rev in $revs do - rev=$(git-rev-parse --verify "$rev") || exit + rev=$(git-rev-parse --verify "$rev^{commit}") || exit echo "$rev" >"$GIT_DIR/refs/bisect/good-$rev" echo "# good: "$(git-show-branch $rev) >>"$GIT_DIR/BISECT_LOG" echo "git-bisect good $rev" >>"$GIT_DIR/BISECT_LOG" |