diff options
authorRené Scharfe <>2017-12-07 20:51:26 (GMT)
committerJunio C Hamano <>2017-12-07 21:19:23 (GMT)
commitc3ff8f6c145638afe996b51e91375fd94cd064d0 (patch)
parent9752ad0bb79f680bca48db7adc45338b298304b0 (diff)
strbuf: release memory on read error in strbuf_read_once()
If other strbuf add functions cause the first allocation and subsequently encounter an error then they release the memory, restoring the pristine state of the strbuf. That simplifies error handling for callers. Do the same in strbuf_read_once(), and do it also in case no bytes were read -- which may or may not be an error as well, depending on the caller. Signed-off-by: Rene Scharfe <> Signed-off-by: Junio C Hamano <>
1 files changed, 3 insertions, 0 deletions
diff --git a/strbuf.c b/strbuf.c
index ace58e7..0809bca 100644
--- a/strbuf.c
+++ b/strbuf.c
@@ -393,12 +393,15 @@ ssize_t strbuf_read(struct strbuf *sb, int fd, size_t hint)
ssize_t strbuf_read_once(struct strbuf *sb, int fd, size_t hint)
+ size_t oldalloc = sb->alloc;
ssize_t cnt;
strbuf_grow(sb, hint ? hint : 8192);
cnt = xread(fd, sb->buf + sb->len, sb->alloc - sb->len - 1);
if (cnt > 0)
strbuf_setlen(sb, sb->len + cnt);
+ else if (oldalloc == 0)
+ strbuf_release(sb);
return cnt;