summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJunio C Hamano <gitster@pobox.com>2018-02-15 22:55:44 (GMT)
committerJunio C Hamano <gitster@pobox.com>2018-02-15 22:55:44 (GMT)
commitab66fc2705b35833582d74a8cd90ac0cf7586f89 (patch)
treebd62d17845c5da6397f1849a1cb4fa7a38fb667d
parent090dbea6843f860de8c981d97d031621176fc2be (diff)
parentae239fc8e57a5758e9db63c0bceaca933d217f81 (diff)
downloadgit-ab66fc2705b35833582d74a8cd90ac0cf7586f89.zip
git-ab66fc2705b35833582d74a8cd90ac0cf7586f89.tar.gz
git-ab66fc2705b35833582d74a8cd90ac0cf7586f89.tar.bz2
Merge branch 'rs/cocci-strbuf-addf-to-addstr'
* rs/cocci-strbuf-addf-to-addstr: cocci: simplify check for trivial format strings
-rw-r--r--contrib/coccinelle/strbuf.cocci17
1 files changed, 1 insertions, 16 deletions
diff --git a/contrib/coccinelle/strbuf.cocci b/contrib/coccinelle/strbuf.cocci
index 6fe8727..e34eada 100644
--- a/contrib/coccinelle/strbuf.cocci
+++ b/contrib/coccinelle/strbuf.cocci
@@ -1,21 +1,6 @@
@ strbuf_addf_with_format_only @
expression E;
-constant fmt;
-@@
- strbuf_addf(E,
-(
- fmt
-|
- _(fmt)
-)
- );
-
-@ script:python @
-fmt << strbuf_addf_with_format_only.fmt;
-@@
-cocci.include_match("%" not in fmt)
-
-@ extends strbuf_addf_with_format_only @
+constant fmt !~ "%";
@@
- strbuf_addf
+ strbuf_addstr