diff options
authorJeff King <>2017-07-13 15:02:52 (GMT)
committerJunio C Hamano <>2017-07-13 19:42:51 (GMT)
commitaa8a5d144da4e4ec43580831ff4a741538d21db4 (patch)
parent18a2565016d45538345a06cd9b912040b5581fc1 (diff)
ref-filter: make parse_ref_filter_atom a private function
The parse_ref_filter_atom() function really shouldn't be exposed outside of ref-filter.c; its return value is an integer index into an array that is private in that file. Since the previous commit removed the sole external caller (and replaced it with a public function at a more appropriately level), we can just make this static. Signed-off-by: Jeff King <> Signed-off-by: Junio C Hamano <>
2 files changed, 1 insertions, 3 deletions
diff --git a/ref-filter.c b/ref-filter.c
index 4321212..ee97d72 100644
--- a/ref-filter.c
+++ b/ref-filter.c
@@ -364,7 +364,7 @@ struct atom_value {
* Used to parse format string and sort specifiers
-int parse_ref_filter_atom(const char *atom, const char *ep)
+static int parse_ref_filter_atom(const char *atom, const char *ep)
const char *sp;
const char *arg;
diff --git a/ref-filter.h b/ref-filter.h
index 67fa626..1ffc3ca 100644
--- a/ref-filter.h
+++ b/ref-filter.h
@@ -104,8 +104,6 @@ struct ref_format {
int filter_refs(struct ref_array *array, struct ref_filter *filter, unsigned int type);
/* Clear all memory allocated to ref_array */
void ref_array_clear(struct ref_array *array);
-/* Parse format string and sort specifiers */
-int parse_ref_filter_atom(const char *atom, const char *ep);
/* Used to verify if the given format is correct and to parse out the used atoms */
int verify_ref_format(struct ref_format *format);
/* Sort the given ref_array as per the ref_sorting provided */