summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJunio C Hamano <junkio@cox.net>2007-02-25 07:18:11 (GMT)
committerShawn O. Pearce <spearce@spearce.org>2007-02-25 07:18:26 (GMT)
commit92446aba47b0e0db28f7b858ea387efcca30ab44 (patch)
treefcd892d57e03be7b4baa1d97a94d8d969e4ed602
parent981193786fc30b9ee73b9f223a75642b4ed455b9 (diff)
downloadgit-92446aba47b0e0db28f7b858ea387efcca30ab44.zip
git-92446aba47b0e0db28f7b858ea387efcca30ab44.tar.gz
git-92446aba47b0e0db28f7b858ea387efcca30ab44.tar.bz2
Don't modify CREDITS-FILE if it hasn't changed.
We should always avoid rewriting a built file during `make install` if nothing has changed since `make all`. This is to help support the typical installation process of compiling a package as yourself, then installing it as root. Forcing CREDITS-FILE to be always be rebuilt in the Makefile means that CREDITS-GEN needs to check for a change and only update CREDITS-FILE if the file content actually differs. After all, content is king in Git. Signed-off-by: Junio C Hamano <junkio@cox.net> Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
-rwxr-xr-xCREDITS-GEN25
1 files changed, 19 insertions, 6 deletions
diff --git a/CREDITS-GEN b/CREDITS-GEN
index da2c076..d1b0f86 100755
--- a/CREDITS-GEN
+++ b/CREDITS-GEN
@@ -20,8 +20,8 @@ tree_search ()
generate_credits ()
{
tip=$1 &&
- rm -f $CF &&
- git shortlog -n -s $tip | sed 's/: .*$//' >$CF || exit
+ rm -f "$2" &&
+ git shortlog -n -s $tip | sed 's/: .*$//' >"$2" || exit
}
# Always use the tarball credits file if found, just
@@ -36,10 +36,14 @@ generate_credits ()
# that fact.
#
+credits_tmp=/var/tmp/gitgui-credits-$$
+trap 'rm -f "$credits_tmp"' 0
+
+orig="$credits_tmp"
+
if test -f credits
then
- rm -f $CF &&
- cp credits $CF || exit
+ orig=credits
elif prefix="$(git rev-parse --show-prefix 2>/dev/null)" &&
test -n "$prefix" &&
head=$(git rev-list --max-count=1 HEAD -- . 2>/dev/null) &&
@@ -47,12 +51,21 @@ elif prefix="$(git rev-parse --show-prefix 2>/dev/null)" &&
tip=$(tree_search $head $tree) &&
test -n "$tip"
then
- generate_credits $tip || exit
+ generate_credits $tip "$orig" || exit
elif tip="$(git rev-parse --verify HEAD 2>/dev/null)" &&
test -n "$tip"
then
- generate_credits $tip || exit
+ generate_credits $tip "$orig" || exit
else
echo "error: Cannot locate authorship information." >&2
exit 1
fi
+
+if test -f "$orig" && cmp -s "$orig" "$CF"
+then
+ : noop
+else
+ rm -f "$CF" &&
+ cat "$orig" >"$CF"
+fi
+