diff options
authorJunio C Hamano <>2014-12-22 20:26:38 (GMT)
committerJunio C Hamano <>2014-12-22 20:26:38 (GMT)
commit63296d583ca107b3f590c3a09be9b3670a2c1afb (patch)
parent168ab99d4c0a3587cee18ef8300f78d4c4344a66 (diff)
parent53de742470bdf160a8412d7a2e9c30545db63fac (diff)
Merge branch 'jc/refer-to-t-readme-from-submitting-patches'
* jc/refer-to-t-readme-from-submitting-patches: t/README: justify why "! grep foo" is sufficient SubmittingPatches: refer to t/README for tests
2 files changed, 4 insertions, 2 deletions
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index fa71b5f..e3c942e 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -57,7 +57,8 @@ change, the approach taken by the change, and if relevant how this
differs substantially from the prior version, are all good things
to have.
-Make sure that you have tests for the bug you are fixing.
+Make sure that you have tests for the bug you are fixing. See
+t/README for guidance.
When adding a new feature, make sure that you have new tests to show
the feature triggers the new behaviour when it should, and to show the
diff --git a/t/README b/t/README
index 9952261..d5bb0c9 100644
--- a/t/README
+++ b/t/README
@@ -418,7 +418,8 @@ Don't:
dies in an unexpected way (e.g. segfault).
On the other hand, don't use test_must_fail for running regular
- platform commands; just use '! cmd'.
+ platform commands; just use '! cmd'. We are not in the business
+ of verifying that the world given to us sanely works.
- use perl without spelling it as "$PERL_PATH". This is to help our
friends on Windows where the platform Perl often adds CR before