summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJim Meyering <jim@meyering.net>2007-12-08 15:48:05 (GMT)
committerJunio C Hamano <gitster@pobox.com>2007-12-08 22:24:13 (GMT)
commit6281f394674bf2db861967da6c2215cfc3fc78af (patch)
treefdfab53d81a1e017d1d12c45bb1e88eee3f606fe
parent8e7425da782cbdff4531d84e0ef4ec7bd3ae23d7 (diff)
downloadgit-6281f394674bf2db861967da6c2215cfc3fc78af.zip
git-6281f394674bf2db861967da6c2215cfc3fc78af.tar.gz
git-6281f394674bf2db861967da6c2215cfc3fc78af.tar.bz2
config.c:store_write_pair(): don't read the byte before a malloc'd buffer.
Signed-off-by: Jim Meyering <meyering@redhat.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--config.c10
1 files changed, 8 insertions, 2 deletions
diff --git a/config.c b/config.c
index 56e99fc..914cfce 100644
--- a/config.c
+++ b/config.c
@@ -630,13 +630,19 @@ static int store_write_pair(int fd, const char* key, const char* value)
int length = strlen(key+store.baselen+1);
int quote = 0;
- /* Check to see if the value needs to be quoted. */
+ /*
+ * Check to see if the value needs to be surrounded with a dq pair.
+ * Note that problematic characters are always backslash-quoted; this
+ * check is about not losing leading or trailing SP and strings that
+ * follow beginning-of-comment characters (i.e. ';' and '#') by the
+ * configuration parser.
+ */
if (value[0] == ' ')
quote = 1;
for (i = 0; value[i]; i++)
if (value[i] == ';' || value[i] == '#')
quote = 1;
- if (value[i-1] == ' ')
+ if (i && value[i-1] == ' ')
quote = 1;
if (write_in_full(fd, "\t", 1) != 1 ||