summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRobert Luberda <robert@debian.org>2019-10-27 09:14:26 (GMT)
committerJunio C Hamano <gitster@pobox.com>2019-10-28 02:06:57 (GMT)
commit52bd3e46574baecf06562d4da857ba445981beb9 (patch)
tree3c61638bec9354e9a5877eb1ce3f2cbbd70624af
parent5fa0f5238b0cd46cfe7f6fa76c3f526ea98148d9 (diff)
downloadgit-52bd3e46574baecf06562d4da857ba445981beb9.zip
git-52bd3e46574baecf06562d4da857ba445981beb9.tar.gz
git-52bd3e46574baecf06562d4da857ba445981beb9.tar.bz2
gitweb: correctly store previous rev in javascript-actions mode
Without this change, the setting $feature{'javascript-actions'}{'default'} = [1]; in gitweb.conf breaks gitweb's blame page: clicking on line numbers displayed in the second column on the page has no effect. For comparison, with javascript-actions disabled, clicking on line numbers loads the previous version of the line. Addresses https://bugs.debian.org/741883. Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Robert Luberda <robert@debian.org> Acked-by: Jakub Narębski <jnareb@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--gitweb/static/js/blame_incremental.js2
1 files changed, 1 insertions, 1 deletions
diff --git a/gitweb/static/js/blame_incremental.js b/gitweb/static/js/blame_incremental.js
index db6eb50..e100d82 100644
--- a/gitweb/static/js/blame_incremental.js
+++ b/gitweb/static/js/blame_incremental.js
@@ -484,7 +484,7 @@ function processBlameLines(lines) {
case 'previous':
curCommit.nprevious++;
// store only first 'previous' header
- if (!'previous' in curCommit) {
+ if (!('previous' in curCommit)) {
var parts = data.split(' ', 2);
curCommit.previous = parts[0];
curCommit.file_parent = unquote(parts[1]);