summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJunio C Hamano <gitster@pobox.com>2011-03-23 04:37:59 (GMT)
committerJunio C Hamano <gitster@pobox.com>2011-03-23 04:37:59 (GMT)
commit4b28cd9f2fb755cdfe1b97130e84644ae932988c (patch)
treec48bc072cd6d6d6b27f4bf1e38c2481bb6a4ace6
parent91b3c7ce8e189b90d3203265c9625806a15045e1 (diff)
parent6e7d0efa9058aa61147d9d18b33bd046055584e4 (diff)
downloadgit-4b28cd9f2fb755cdfe1b97130e84644ae932988c.zip
git-4b28cd9f2fb755cdfe1b97130e84644ae932988c.tar.gz
git-4b28cd9f2fb755cdfe1b97130e84644ae932988c.tar.bz2
Merge branch 'jc/maint-rev-list-culled-boundary'
* jc/maint-rev-list-culled-boundary: list-objects.c: don't add an unparsed NULL as a pending tree Conflicts: list-objects.c
-rw-r--r--list-objects.c7
-rwxr-xr-xt/t6110-rev-list-sparse.sh20
2 files changed, 26 insertions, 1 deletions
diff --git a/list-objects.c b/list-objects.c
index 61f6cc9..838b6a7 100644
--- a/list-objects.c
+++ b/list-objects.c
@@ -173,7 +173,12 @@ void traverse_commit_list(struct rev_info *revs,
strbuf_init(&base, PATH_MAX);
while ((commit = get_revision(revs)) != NULL) {
- add_pending_tree(revs, commit->tree);
+ /*
+ * an uninteresting boundary commit may not have its tree
+ * parsed yet, but we are not going to show them anyway
+ */
+ if (commit->tree)
+ add_pending_tree(revs, commit->tree);
show_commit(commit, data);
}
for (i = 0; i < revs->pending.nr; i++) {
diff --git a/t/t6110-rev-list-sparse.sh b/t/t6110-rev-list-sparse.sh
new file mode 100755
index 0000000..656ac7f
--- /dev/null
+++ b/t/t6110-rev-list-sparse.sh
@@ -0,0 +1,20 @@
+#!/bin/sh
+
+test_description='operations that cull histories in unusual ways'
+. ./test-lib.sh
+
+test_expect_success setup '
+ test_commit A &&
+ test_commit B &&
+ test_commit C &&
+ git checkout -b side HEAD^ &&
+ test_commit D &&
+ test_commit E &&
+ git merge master
+'
+
+test_expect_success 'rev-list --first-parent --boundary' '
+ git rev-list --first-parent --boundary HEAD^..
+'
+
+test_done