diff options
| author | Eric Wong <normalperson@yhbt.net> | 2006-06-10 06:27:01 (GMT) |
|---|---|---|
| committer | Eric Wong <normalperson@yhbt.net> | 2006-06-16 10:04:19 (GMT) |
| commit | 4a393f2b53f0997f79d47793d4c774fa0072887c (patch) | |
| tree | ab843830869fea41829fec96a6e1d1505b229203 | |
| parent | 8a97e368882afbc2bdc030214339bed54ed6545c (diff) | |
| download | git-4a393f2b53f0997f79d47793d4c774fa0072887c.zip git-4a393f2b53f0997f79d47793d4c774fa0072887c.tar.gz git-4a393f2b53f0997f79d47793d4c774fa0072887c.tar.bz2 | |
git-svn: eol_cp corner-case fixes
If we read the maximum size of our buffer into $buf, and the
last character is '\015', there's a chance that the character is
'\012', which means our regex won't work correctly. At the
worst case, this could introduce an extra newline into the code.
We'll now read an extra character if we see '\015' is the last
character in $buf.
We also forgot to recalculate the length of $buf after doing the
newline substitution, causing some files to appeare truncated.
We'll do that now and force byte semantics in length() for good
measure.
Signed-off-by: Eric Wong <normalperson@yhbt.net>
| -rwxr-xr-x | contrib/git-svn/git-svn.perl | 15 |
1 files changed, 11 insertions, 4 deletions
diff --git a/contrib/git-svn/git-svn.perl b/contrib/git-svn/git-svn.perl index 7ed11ef..8d2e7f7 100755 --- a/contrib/git-svn/git-svn.perl +++ b/contrib/git-svn/git-svn.perl @@ -866,19 +866,26 @@ sub eol_cp { binmode $wfd or croak $!; my $eol = $EOL{$es} or undef; - if ($eol) { - print "$eol: $from => $to\n"; - } my $buf; + use bytes; while (1) { my ($r, $w, $t); defined($r = sysread($rfd, $buf, 4096)) or croak $!; return unless $r; - $buf =~ s/(?:\015|\012|\015\012)/$eol/gs if $eol; + if ($eol) { + if ($buf =~ /\015$/) { + my $c; + defined($r = sysread($rfd,$c,1)) or croak $!; + $buf .= $c if $r > 0; + } + $buf =~ s/(?:\015\012|\015|\012)/$eol/gs; + $r = length($buf); + } for ($w = 0; $w < $r; $w += $t) { $t = syswrite($wfd, $buf, $r - $w, $w) or croak $!; } } + no bytes; } sub do_update_index { |