summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJeff King <peff@peff.net>2016-08-03 23:01:04 (GMT)
committerJunio C Hamano <gitster@pobox.com>2016-08-05 16:28:16 (GMT)
commit46ac74b71681f1d2ff29615236193e651dcdd9fe (patch)
treef25c09a702b581d49a3a8ab76c817ff45e597958
parent3b0c3ab777d7d1fc2fbfaba9ec8ce4d845428d99 (diff)
downloadgit-46ac74b71681f1d2ff29615236193e651dcdd9fe.zip
git-46ac74b71681f1d2ff29615236193e651dcdd9fe.tar.gz
git-46ac74b71681f1d2ff29615236193e651dcdd9fe.tar.bz2
trace: disable key after write error
If we get a write error writing to a trace descriptor, the error isn't likely to go away if we keep writing. Instead, you'll just get the same error over and over. E.g., try: GIT_TRACE_PACKET=42 git ls-remote >/dev/null You don't really need to see: warning: unable to write trace for GIT_TRACE_PACKET: Bad file descriptor hundreds of times. We could fallback to tracing to stderr, as we do in the error code-path for open(), but there's not much point. If the user fed us a bogus descriptor, they're probably better off fixing their invocation. And if they didn't, and we saw a transient error (e.g., ENOSPC writing to a file), it probably doesn't help anybody to have half of the trace in a file, and half on stderr. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--trace.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/trace.c b/trace.c
index 4efb256..083eb98 100644
--- a/trace.c
+++ b/trace.c
@@ -134,6 +134,7 @@ static void trace_write(struct trace_key *key, const void *buf, unsigned len)
normalize_trace_key(&key);
warning("unable to write trace for %s: %s",
key->key, strerror(errno));
+ trace_disable(key);
}
}