diff options
authorJunio C Hamano <>2008-02-11 18:41:18 (GMT)
committerJunio C Hamano <>2008-02-11 21:11:36 (GMT)
commit40ea4ed9032a80c9dba706d6030bd11b08c35f4d (patch)
parentc5e5a2c097240e7d51374eef398d388c5ee5cc9b (diff)
Add config_error_nonbool() helper function
This is used to report misconfigured configuration file that does not give any value to a non-boolean variable, e.g. [section] var It is perfectly fine to say it if the section.var is a boolean (it means true), but if a variable expects a string value it should be flagged as a configuration error. Signed-off-by: Junio C Hamano <>
2 files changed, 10 insertions, 0 deletions
diff --git a/cache.h b/cache.h
index 549f4bb..6abcee4 100644
--- a/cache.h
+++ b/cache.h
@@ -589,6 +589,7 @@ extern int git_config_set_multivar(const char *, const char *, const char *, int
extern int git_config_rename_section(const char *, const char *);
extern const char *git_etc_gitconfig(void);
extern int check_repository_format_version(const char *var, const char *value);
+extern int config_error_nonbool(const char *);
#define MAX_GITNAME (1000)
extern char git_default_email[MAX_GITNAME];
diff --git a/config.c b/config.c
index e799f40..03c94a2 100644
--- a/config.c
+++ b/config.c
@@ -1079,3 +1079,12 @@ int git_config_rename_section(const char *old_name, const char *new_name)
return ret;
+ * Call this to report error for your variable that should not
+ * get a boolean value (i.e. "[my] var" means "true").
+ */
+int config_error_nonbool(const char *var)
+ return error("Missing value for '%s'", var);