summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJohannes Schindelin <johannes.schindelin@gmx.de>2019-12-02 11:33:29 (GMT)
committerJunio C Hamano <gitster@pobox.com>2019-12-02 19:05:36 (GMT)
commit3ba3720b3f187644ac0186a4637898f8e8f85a91 (patch)
tree058bc3d372ba1317d96dd781f90f9a3e9b7061f4
parent4d0375ca24f6e317e94705e74c89f33c66c35107 (diff)
downloadgit-3ba3720b3f187644ac0186a4637898f8e8f85a91.zip
git-3ba3720b3f187644ac0186a4637898f8e8f85a91.tar.gz
git-3ba3720b3f187644ac0186a4637898f8e8f85a91.tar.bz2
mingw: forbid translating ERROR_SUCCESS to an errno value
Johannes Sixt pointed out that the `err_win_to_posix()` function mishandles `ERROR_SUCCESS`: it maps it to `ENOSYS`. The only purpose of this function is to map Win32 API errors to `errno` ones, and there is actually no equivalent to `ERROR_SUCCESS`: the idea of `errno` is that it will only be set in case of an error, and left alone in case of success. Therefore, as pointed out by Junio Hamano, it is a bug to call this function when there was not even any error to map. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--compat/mingw.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/compat/mingw.c b/compat/mingw.c
index 432adc1..827065d 100644
--- a/compat/mingw.c
+++ b/compat/mingw.c
@@ -114,6 +114,7 @@ int err_win_to_posix(DWORD winerr)
case ERROR_SHARING_BUFFER_EXCEEDED: error = ENFILE; break;
case ERROR_SHARING_VIOLATION: error = EACCES; break;
case ERROR_STACK_OVERFLOW: error = ENOMEM; break;
+ case ERROR_SUCCESS: BUG("err_win_to_posix() called without an error!");
case ERROR_SWAPERROR: error = ENOENT; break;
case ERROR_TOO_MANY_MODULES: error = EMFILE; break;
case ERROR_TOO_MANY_OPEN_FILES: error = EMFILE; break;