summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJunio C Hamano <gitster@pobox.com>2014-06-06 18:38:54 (GMT)
committerJunio C Hamano <gitster@pobox.com>2014-06-06 18:38:54 (GMT)
commit3784ba310fbb14ca96d7faeeefad1d8985c5de86 (patch)
tree6e15d668e3cb16234d5e72fb72768ce2b8673043
parent3ea8ecc21ec87eb5173a7145db2d3653e5b5fa28 (diff)
parent561b46c5c8a9d204974e6edd4f58a5fca343d6d3 (diff)
downloadgit-3784ba310fbb14ca96d7faeeefad1d8985c5de86.zip
git-3784ba310fbb14ca96d7faeeefad1d8985c5de86.tar.gz
git-3784ba310fbb14ca96d7faeeefad1d8985c5de86.tar.bz2
Merge branch 'jn/test-lint-unmoor'
* jn/test-lint-unmoor: test-lint: find unportable sed, echo, test, and export usage after &&
-rwxr-xr-xt/check-non-portable-shell.pl8
1 files changed, 4 insertions, 4 deletions
diff --git a/t/check-non-portable-shell.pl b/t/check-non-portable-shell.pl
index 45971f4..b170cbc 100755
--- a/t/check-non-portable-shell.pl
+++ b/t/check-non-portable-shell.pl
@@ -16,12 +16,12 @@ sub err {
while (<>) {
chomp;
- /^\s*sed\s+-i/ and err 'sed -i is not portable';
- /^\s*echo\s+-n/ and err 'echo -n is not portable (please use printf)';
+ /\bsed\s+-i/ and err 'sed -i is not portable';
+ /\becho\s+-n/ and err 'echo -n is not portable (please use printf)';
/^\s*declare\s+/ and err 'arrays/declare not portable';
/^\s*[^#]\s*which\s/ and err 'which is not portable (please use type)';
- /test\s+[^=]*==/ and err '"test a == b" is not portable (please use =)';
- /^\s*export\s+[^=]*=/ and err '"export FOO=bar" is not portable (please use FOO=bar && export FOO)';
+ /\btest\s+[^=]*==/ and err '"test a == b" is not portable (please use =)';
+ /\bexport\s+[A-Za-z0-9_]*=/ and err '"export FOO=bar" is not portable (please use FOO=bar && export FOO)';
# this resets our $. for each file
close ARGV if eof;
}