summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJohannes Sixt <j6t@kdbg.org>2009-02-07 15:08:27 (GMT)
committerJunio C Hamano <gitster@pobox.com>2009-02-07 20:23:29 (GMT)
commit2cd85c40a9f396bb24f7861c832acd52e61c4780 (patch)
tree6a90b7cc79938c5fbdba4a043bd4d8b695b38ba0
parentab2fdb3b62589477bde0cd0af8239bee510c3488 (diff)
downloadgit-2cd85c40a9f396bb24f7861c832acd52e61c4780.zip
git-2cd85c40a9f396bb24f7861c832acd52e61c4780.tar.gz
git-2cd85c40a9f396bb24f7861c832acd52e61c4780.tar.bz2
Make test-path-utils more robust against incorrect use
Previously, this test utility happily returned with exit code 0 if garbage was thrown at it. Now it reports failure if an unknown function name was given on the command line. Signed-off-by: Johannes Sixt <j6t@kdbg.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--test-path-utils.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/test-path-utils.c b/test-path-utils.c
index 2c0f5a3..7e6fc8d 100644
--- a/test-path-utils.c
+++ b/test-path-utils.c
@@ -7,6 +7,7 @@ int main(int argc, char **argv)
int rv = normalize_absolute_path(buf, argv[2]);
assert(strlen(buf) == rv);
puts(buf);
+ return 0;
}
if (argc >= 2 && !strcmp(argv[1], "make_absolute_path")) {
@@ -15,12 +16,16 @@ int main(int argc, char **argv)
argc--;
argv++;
}
+ return 0;
}
if (argc == 4 && !strcmp(argv[1], "longest_ancestor_length")) {
int len = longest_ancestor_length(argv[2], argv[3]);
printf("%d\n", len);
+ return 0;
}
- return 0;
+ fprintf(stderr, "%s: unknown function name: %s\n", argv[0],
+ argv[1] ? argv[1] : "(there was none)");
+ return 1;
}