summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRené Scharfe <rene.scharfe@lsrfire.ath.cx>2007-07-24 21:29:29 (GMT)
committerJunio C Hamano <gitster@pobox.com>2007-07-25 00:28:10 (GMT)
commit24d00634948452d0bec1b373b6a2eb9145fc8bfc (patch)
tree2af3d5a20fe6685dd6f3dd13df3ad976b45d41c1
parent3473e7df5f8c7f8dc3e2c3f2fdc99a1d1a719c16 (diff)
downloadgit-24d00634948452d0bec1b373b6a2eb9145fc8bfc.zip
git-24d00634948452d0bec1b373b6a2eb9145fc8bfc.tar.gz
git-24d00634948452d0bec1b373b6a2eb9145fc8bfc.tar.bz2
filter-branch: fix dash complaining about "Missing '))'"
On e.g. Ubuntu, dash is used as /bin/sh. Unlike bash it parses commands like a=$((echo stuff) | wc) as an arithmetic expression while what we want is a subshell inside a command substitution. Resolve the ambiguity by placing a space between the two opening parentheses. Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rwxr-xr-xgit-filter-branch.sh2
1 files changed, 1 insertions, 1 deletions
diff --git a/git-filter-branch.sh b/git-filter-branch.sh
index 0ff3475..b5fa449 100755
--- a/git-filter-branch.sh
+++ b/git-filter-branch.sh
@@ -298,7 +298,7 @@ do
# Assign the boundarie(s) in the set of rewritten commits
# as the replacement commit(s).
# (This would look a bit nicer if --not --stdin worked.)
- for p in $((cd "$workdir"/../map; ls | sed "s/^/^/") |
+ for p in $( (cd "$workdir"/../map; ls | sed "s/^/^/") |
git rev-list $ref --boundary --stdin |
sed -n "s/^-//p")
do